[opencms-dev] How to code-review

[Tobias Herrmann]

Hi Alberto,

under which circumstances do you end up with wrong binaries?

Also, the test cases do take time to execute, this is not related to any 
possible inefficiencies of the build script. You don't need to run the 
test cases to build the binaries.

Other tasks that take a lot of time are generating GWT resources, this 
is a general issue with GWT and not related to the build script.

And if you build the JavaDoc jars this will take a lot of time as well, 
but this is related to the amount of source code and not to the build 
script.

So, if you think there is a way to significantly safe time during build, 
please point out, what you think should be changed.

Kind regards,

Tobias

-------------------

Tobias Herrmann

Alkacon Software GmbH & Co. KG  - The OpenCms Experts
http://www.alkacon.com - http://www.opencms.org
Am 20.06.2017 um 14:26 schrieb Alberto Gallardo:
> Hi Tobias,
> 
>     I was wondering why you were commenting on the gradle build script
>     code and issuing pull request with minor changes, as the build
>     script just works for us.
> 
> 
> The 'work for us' part is what is a bit tricky. It does work under 
> certain circumstances, but it can lead to wrong binaries if not handled 
> with care ;-) It also is a bit inefficient, and given that the whole 
> build (with tests) takes more than half an hour in our servers, any 
> improvement would be welcome.
> 
>     Currently I am very busy, so I was reluctant to merge cosmetic
>     changes into the build script.
> 
> 
> That was also my assumption. I agree that these changes are only of 
> 'cosmetic' nature (though I would prefer to say that they improve the 
> "-ilities" of the build)
> 
> 
>     If you need changes to the build script for better integration into
>     NetBeans or IDEA, please got ahead and issue a pull request.
> 
> 
> I'll merge the current PRs into one, so if you want to merge we don't 
> end up with too many commits.
> 
> 
> Bests,
> 
> Alberto
> 
> 
> _______________________________________________
> This mail is sent to you from the opencms-dev mailing list
> To change your list options, or to unsubscribe from the list, please visit
> http://lists.opencms.org/cgi-bin/mailman/listinfo/opencms-dev
> 
> 
>