[opencms-dev] How to code-review

[Tobias Herrmann]

Hi Alberto,

I was wondering why you were commenting on the gradle build script code 
and issuing pull request with minor changes, as the build script just 
works for us. Currently I am very busy, so I was reluctant to merge 
cosmetic changes into the build script.

If you need changes to the build script for better integration into 
NetBeans or IDEA, please got ahead and issue a pull request. Please also 
state, what you changed and why it is necessary. That makes testing 
easier for me.


Kind regards,

Tobias

-------------------

Tobias Herrmann

Alkacon Software GmbH & Co. KG  - The OpenCms Experts
http://www.alkacon.com - http://www.opencms.org
Am 20.06.2017 um 10:37 schrieb Alberto Gallardo:
> Hi Alkacon,
> 
> I now and then have to debug some code, but there are some aspects of 
> the build script that are not well supported in my IDE and that prevent 
> a satisfactory debugging session. (I have already tried NetBeans and now 
> I'm using IDEA, but both of them have their issues.) So I was forced to 
> review the build script.
> 
> There are definitely some fragments that can be improved, and I already 
> published some PR and comments to try to improve it:
> 
> https://github.com/alkacon/opencms-core/pull/483
> https://github.com/alkacon/opencms-core/pull/506
> https://github.com/alkacon/opencms-core/pull/507
> https://github.com/alkacon/opencms-core/commit/4414fe40f19b54c8e71d6953b1fd574f4d8cf56d#commitcomment-22622726
> 
> But slowly I get the impression that for this kind of collaborations, we 
> yet not have the appropriate tools:
> - reviewing code via email lists is too cumbersome and would introduce 
> too much noise.
> - GitHub comments are pretty limited (I have to first find when a line 
> was committed, and I can only comment on commits).
> - GitHub Pull request are also too heavy for this goal: I would be 
> writing too many PR just to improve one file.
> - The gitter chat room (https://gitter.im/opencms-community) is almost dead.
> 
> So I was wandering how I could efficiently provide some feedback to your 
> files when this necessity arises. Should I keep on writing PRs?
> 
> 
> Best regards,
> 
> 
> Alberto Gallardo
> 
> 
> _______________________________________________
> This mail is sent to you from the opencms-dev mailing list
> To change your list options, or to unsubscribe from the list, please visit
> http://lists.opencms.org/cgi-bin/mailman/listinfo/opencms-dev
> 
> 
>